HTTP Request Compression for ADBRO Bid Adapter#2
Closed
inebritov wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
ashvetsov
requested changes
Jan 16, 2026
| expect(serverRequest.url).to.exist; | ||
| expect(serverRequest.url).to.equal('https://prebid.adbro.me/pbjs?placementId=1234'); | ||
| expect(serverRequest.options).to.exist; | ||
| expect(serverRequest.options.endpointCompression).to.be.true; |
There was a problem hiding this comment.
Please create a dedicated test case within the same group:
it('Configures compression for the ServerRequest object', function () {
const serverRequest = serverRequests[0];
expect(serverRequest.options).to.exist;
expect(serverRequest.options.endpointCompression).to.be.true;
}It's always better to add new test cases than to modify existing ones.
…tatement Signed-off-by: Ivan Nebritov <inebritov@adbro.me>
Pull Request Test Coverage Report for Build 21059761616Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
ashvetsov
approved these changes
Jan 16, 2026
inebritov
pushed a commit
that referenced
this pull request
Jun 23, 2026
* Start.io - Create User ID submodule and improve adapter * Update modules/startioIdSystem.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix: Adjust spacing formatting in getStorageManager parameters * Fix: Adjust spacing formatting in getStorageManager parameters (#2) * Refactor: Remove unused storage management logic from StartIO ID module and set default storage expiration * Refactor: Remove unused storage management logic from StartIO ID module and set default storage expiration * Enhance: Add configurable storage options and expiration to StartIO ID module * Docs: Update StartIO ID module documentation with storage configuration details * Docs: Update StartIO ID module documentation with storage configuration details --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
inebritov
pushed a commit
that referenced
this pull request
Jun 23, 2026
…rebid#14650) * Start.io - Create User ID submodule and improve adapter * Update modules/startioIdSystem.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix: Adjust spacing formatting in getStorageManager parameters * Fix: Adjust spacing formatting in getStorageManager parameters (#2) * Refactor: Remove unused storage management logic from StartIO ID module and set default storage expiration * Refactor: Remove unused storage management logic from StartIO ID module and set default storage expiration * Enhance: Add configurable storage options and expiration to StartIO ID module * Docs: Update StartIO ID module documentation with storage configuration details * Docs: Update StartIO ID module documentation with storage configuration details * Docs: Add build instructions and module details to Start.io ID system file (prebid#4) * Docs: Add build instructions and module details to Start.io ID system documentation (prebid#5) * Apply suggestion from @IlliaMil --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Matan Arbel <matan.arbel@start.io>
inebritov
pushed a commit
that referenced
this pull request
Jun 23, 2026
* Start.io - Create User ID submodule and improve adapter * Update modules/startioIdSystem.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix: Adjust spacing formatting in getStorageManager parameters * Fix: Adjust spacing formatting in getStorageManager parameters (#2) * Refactor: Remove unused storage management logic from StartIO ID module and set default storage expiration * Refactor: Remove unused storage management logic from StartIO ID module and set default storage expiration * Enhance: Add configurable storage options and expiration to StartIO ID module * Docs: Update StartIO ID module documentation with storage configuration details * Docs: Update StartIO ID module documentation with storage configuration details * Docs: Add build instructions and module details to Start.io ID system file (prebid#4) * Docs: Add build instructions and module details to Start.io ID system documentation (prebid#5) * Apply suggestion from @IlliaMil * Enable credentials in StartIO bid adapter requests (prebid#6) --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Matan Arbel <matan.arbel@start.io>
Collaborator
Author
|
Merged in prebid repo master, see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.